Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize the reflection operation in class SerializerServiceLoader #6780

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

wangliang181230
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

optimize: Optimize the reflection operation in class SerializerServiceLoader

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@wangliang181230 wangliang181230 changed the title optimize: Optimize the reflection operation in class SerializerServiceLoader optimize: optimize the reflection operation in class SerializerServiceLoader Aug 25, 2024
Copy link

codecov bot commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.22%. Comparing base (8288a57) to head (8a2fcd7).
Report is 1 commits behind head on 2.x.

Files Patch % Lines
...seata/core/serializer/SerializerServiceLoader.java 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6780      +/-   ##
============================================
- Coverage     52.36%   52.22%   -0.15%     
+ Complexity     6306     6293      -13     
============================================
  Files          1064     1064              
  Lines         37179    37181       +2     
  Branches       4415     4415              
============================================
- Hits          19470    19418      -52     
- Misses        15785    15846      +61     
+ Partials       1924     1917       -7     
Files Coverage Δ
...a/org/apache/seata/common/util/ReflectionUtil.java 73.11% <100.00%> (+0.59%) ⬆️
...seata/core/serializer/SerializerServiceLoader.java 60.00% <33.33%> (+6.87%) ⬆️

... and 7 files with indirect coverage changes

@funky-eyes funky-eyes added this to the 2.2.0 milestone Aug 26, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 8af2d84 into apache:2.x Aug 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants