-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix the naming server node having a term of 0 #6778
Merged
funky-eyes
merged 33 commits into
apache:2.x
from
ggbocoder:optimize/optimize_namingserver
Aug 25, 2024
Merged
bugfix: fix the naming server node having a term of 0 #6778
funky-eyes
merged 33 commits into
apache:2.x
from
ggbocoder:optimize/optimize_namingserver
Aug 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md
# Conflicts: # changes/zh-cn/2.x.md
…mingserver # Conflicts: # namingserver/src/main/java/org/apache/seata/namingserver/manager/NamingManager.java
…mingserver # Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md
…mingserver # Conflicts: # namingserver/src/main/java/org/apache/seata/namingserver/manager/NamingManager.java
funky-eyes
reviewed
Aug 24, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6778 +/- ##
=========================================
Coverage 52.15% 52.16%
- Complexity 6294 6295 +1
=========================================
Files 1064 1064
Lines 37215 37214 -1
Branches 4417 4417
=========================================
+ Hits 19411 19413 +2
Misses 15883 15883
+ Partials 1921 1918 -3
|
funky-eyes
approved these changes
Aug 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews