Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Improve the test case coverage of [metrics] module to 70% #6752

Merged
merged 6 commits into from
Aug 31, 2024

Conversation

lightClouds917
Copy link
Contributor

@lightClouds917 lightClouds917 commented Aug 13, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Improve the test case coverage of [metrics] module to 70%

Ⅱ. Does this pull request fix one issue?

fixes #6751

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.34%. Comparing base (525d1b9) to head (d479cd1).
Report is 3 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6752      +/-   ##
============================================
+ Coverage     52.19%   52.34%   +0.14%     
- Complexity     6310     6375      +65     
============================================
  Files          1067     1078      +11     
  Lines         37278    37458     +180     
  Branches       4427     4435       +8     
============================================
+ Hits          19456    19606     +150     
- Misses        15889    15914      +25     
- Partials       1933     1938       +5     

see 14 files with indirect coverage changes

@xingfudeshi xingfudeshi changed the title Test: Improve the test case coverage of [metrics] module to 70% test: Improve the test case coverage of [metrics] module to 70% Aug 18, 2024
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit f5a350d into apache:2.x Aug 31, 2024
7 checks passed
@slievrly slievrly added this to the 2.2.0 milestone Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

task: Improve the test case coverage of [metrics] module to 70%
2 participants