Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize ConsistentHashLoadBalance Algorithm #6748

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

slievrly
Copy link
Member

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

optimize ConsistentHashLoadBalance Algorithm

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (2.x@595277d). Learn more about missing BASE report.

Files Patch % Lines
...scovery/loadbalance/ConsistentHashLoadBalance.java 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##             2.x    #6748   +/-   ##
======================================
  Coverage       ?   50.87%           
  Complexity     ?     5915           
======================================
  Files          ?     1058           
  Lines          ?    36779           
  Branches       ?     4369           
======================================
  Hits           ?    18712           
  Misses         ?    16177           
  Partials       ?     1890           
Files Coverage Δ
...scovery/loadbalance/ConsistentHashLoadBalance.java 85.71% <90.00%> (ø)

@funky-eyes funky-eyes added this to the 2.2.0 milestone Aug 13, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit fff45ce into apache:2.x Aug 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants