-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: Support serialization for dm.jdbc.driver.DmdbTimestamp (#6701) #6728
bugfix: Support serialization for dm.jdbc.driver.DmdbTimestamp (#6701) #6728
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我认为你应该需要在rm-datasource中引入以下依赖
I think you should need to introduce the following dependencies in rm-datasource
<dependency>
<groupId>com.dameng</groupId>
<artifactId>DmJdbcDriver18</artifactId>
<scope>test</scope>
</dependency>
done. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6728 +/- ##
============================================
+ Coverage 50.83% 50.88% +0.04%
- Complexity 5913 5914 +1
============================================
Files 1058 1058
Lines 36717 36772 +55
Branches 4362 4368 +6
============================================
+ Hits 18666 18710 +44
- Misses 16162 16173 +11
Partials 1889 1889
|
...ource/src/test/java/org/apache/seata/rm/datasource/undo/parser/JacksonUndoLogParserTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
This pull request introduces support for serialization and deserialization of the dm.jdbc.driver.DmdbTimestamp class. The changes ensure that environments lacking the DM JDBC driver do not encounter errors or unnecessary logging.
Changes Made
Ⅱ. Does this pull request fix one issue?
fixes #6701
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews