bugfix: fix the issue of xaEnded not being reset #6627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
tanyaofei
force-pushed
the
2.x-fix
branch
2 times, most recently
from
42839cb
to
946cde5
Compare
funky-eyes
changed the title
funky-eyes
changed the title
funky-eyes
approved these changes
Jun 24, 2024
funky-eyes
added
mode: XA
请问2.1已经发了吗，可以合到2.1去吗，这次的修复要跟着上次那个PR一起发版，不然可能会有问题 |
tanyaofei
force-pushed
the
2.x-fix
branch
2 times, most recently
from
9142b86
to
59b43c4
Compare
这个问题出现的概率比较低，而且seata的connectionproxyxa这个connection被放到连接池里复用的概率也很低，除非有datasource去包装seata的datasourceproxyxa进行归还到连接池，否则这个connectionproxyxa对象是一次性的。所以放到2.2没什么太大问题 |
funky-eyes
reviewed
Jun 24, 2024
| @@ -31,5 +32,6 @@ | |||
| - [YeonCheolGit](https://github.com/YeonCheolGit) | |||
| - [liuqiufeng](https://github.com/liuqiufeng) | |||
| - [Bughue](https://github.com/Bughue) | |||
| - [tanyaofei](https://github.com/tanyaofei) | |||
|
@tanyaofei 请把你的钉钉号，通过邮件发送到我的邮箱jianbin@apache.org ，我将邀请你加入seata社区开发者群中，以便沟通 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
用来判断当前是否执行过 XA End 的上下文变量
xaEnded应当在cleanXABranchContext中重置而不是在close中Ⅱ. Does this pull request fix one issue?
fixes #6492
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews