-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Increase [integration-tx-api] module test case coverage #6533
test: Increase [integration-tx-api] module test case coverage #6533
Conversation
Pls register this PR in https://github.com/apache/incubator-seata/tree/2.x/changes |
@xingfudeshi Done |
@xingfudeshi Can you resolve merge conflict? |
Yes.The current version is being released.I'll resolve conflicts after the release. |
How long does it usually take? |
It won’t take long. After version 2.1 is released, I will start addressing the conflicting files in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please resolve the conflict
I can't, I don't have write access to repository. Or should I rebase my branch? |
|
I've fixed the conflicts for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
我修复了codecov没有report成功的问题,现在让我们看看目前的单测覆盖度是多少 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6533 +/- ##
============================================
+ Coverage 50.02% 50.47% +0.44%
- Complexity 5734 5830 +96
============================================
Files 1051 1051
Lines 36340 36340
Branches 4321 4319 -2
============================================
+ Hits 18179 18341 +162
+ Misses 16365 16183 -182
- Partials 1796 1816 +20
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
increase test case coverage of [integration-tx-api] module
Ⅱ. Does this pull request fix one issue?
fixes #6507
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews