Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Increase [integration-tx-api] module test case coverage #6533

Merged
merged 24 commits into from
Jul 29, 2024

Conversation

azatyamanaev
Copy link
Contributor

@azatyamanaev azatyamanaev commented May 12, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

increase test case coverage of [integration-tx-api] module

Ⅱ. Does this pull request fix one issue?

fixes #6507

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@azatyamanaev azatyamanaev marked this pull request as ready for review May 13, 2024 15:50
@xingfudeshi xingfudeshi changed the title Increase [integration-tx-api] module test case coverage test:Increase [integration-tx-api] module test case coverage May 15, 2024
@xingfudeshi xingfudeshi self-requested a review May 15, 2024 09:33
@xingfudeshi
Copy link
Member

Pls register this PR in https://github.com/apache/incubator-seata/tree/2.x/changes

@azatyamanaev
Copy link
Contributor Author

@azatyamanaev
Copy link
Contributor Author

@xingfudeshi Can you resolve merge conflict?

@xingfudeshi
Copy link
Member

@xingfudeshi Can you resolve merge conflict?

Yes.The current version is being released.I'll resolve conflicts after the release.

@azatyamanaev
Copy link
Contributor Author

azatyamanaev commented May 20, 2024

@xingfudeshi Can you resolve merge conflict?

Yes.The current version is being released.I'll resolve conflicts after the release.

How long does it usually take?

@xingfudeshi
Copy link
Member

@xingfudeshi Can you resolve merge conflict?

Yes.The current version is being released.I'll resolve conflicts after the release.

How long does it usually take?

It won’t take long. After version 2.1 is released, I will start addressing the conflicting files in this PR.

@xingfudeshi xingfudeshi added the first-time contributor first-time contributor label May 21, 2024
changes/en-us/2.x.md Show resolved Hide resolved
Copy link
Contributor

@lightClouds917 lightClouds917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolve the conflict

@azatyamanaev
Copy link
Contributor Author

azatyamanaev commented Jun 13, 2024

please resolve the conflict

I can't, I don't have write access to repository. Or should I rebase my branch?

@lightClouds917
Copy link
Contributor

please resolve the conflict

I can't, I don't have write access to repository. Or should I rebase my branch?
you can merge the 2.x branch to your branch,and resolve the confict.

@justinmclean
Copy link
Member

I've fixed the conflicts for you.

Copy link
Contributor

@lightClouds917 lightClouds917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes
Copy link
Contributor

我修复了codecov没有report成功的问题,现在让我们看看目前的单测覆盖度是多少
I've fixed the issue with Codecov not reporting successfully. Now, let's see what the current test coverage percentage is.

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.47%. Comparing base (20cd962) to head (3ebc46d).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6533      +/-   ##
============================================
+ Coverage     50.02%   50.47%   +0.44%     
- Complexity     5734     5830      +96     
============================================
  Files          1051     1051              
  Lines         36340    36340              
  Branches       4321     4319       -2     
============================================
+ Hits          18179    18341     +162     
+ Misses        16365    16183     -182     
- Partials       1796     1816      +20     
Files Coverage Δ
...ta/integration/tx/api/remoting/TwoPhaseResult.java 100.00% <100.00%> (+100.00%) ⬆️

... and 14 files with indirect coverage changes

@funky-eyes funky-eyes changed the title test:Increase [integration-tx-api] module test case coverage test: Increase [integration-tx-api] module test case coverage Jul 29, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 7d3cf99 into apache:2.x Jul 29, 2024
7 checks passed
@funky-eyes funky-eyes added this to the 2.2.0 milestone Jul 29, 2024
@funky-eyes funky-eyes added the module/intergration-tx-api intergration-tx-api label Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor module/intergration-tx-api intergration-tx-api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

task: Improve the test case coverage of [integration-tx-api] module to 70%
6 participants