Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize kotlin-maven-plugin #6521

Open
wants to merge 3 commits into
base: 2.x
Choose a base branch
from

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented May 6, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

optimize kotlin-maven-plugin

Ⅱ. Does this pull request fix one issue?

fix #6520

https://kotlinlang.org/docs/maven.html#use-jdk-17

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.1.0 milestone May 6, 2024
@slievrly slievrly added the Do Not Merge Do not merge into develop label May 7, 2024
@slievrly slievrly removed this from the 2.1.0 milestone May 7, 2024
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge Do not merge into develop type: optimize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kotlin-maven-plugin compilate failure in Java 17
3 participants