Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix saga mode replay context lost start in 2.x #6465

Merged
merged 2 commits into from
Apr 6, 2024

Conversation

xjlgod
Copy link
Contributor

@xjlgod xjlgod commented Apr 6, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

fix saga mode replay context lost start in 2.x

Ⅱ. Does this pull request fix one issue?

fixes #6257

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Member

@ptyin ptyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.27%. Comparing base (d318409) to head (c4ea9dc).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6465      +/-   ##
============================================
- Coverage     50.81%   50.27%   -0.55%     
+ Complexity     5285     5244      -41     
============================================
  Files           942      942              
  Lines         33270    33270              
  Branches       4030     4030              
============================================
- Hits          16907    16726     -181     
- Misses        14698    14927     +229     
+ Partials       1665     1617      -48     

see 46 files with indirect coverage changes

@ptyin ptyin requested a review from wt-better April 6, 2024 13:40
@funky-eyes funky-eyes changed the title fix(6257): fix saga mode replay context lost start in 2.x bugfix: fix saga mode replay context lost start in 2.x Apr 6, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.1.0 milestone Apr 6, 2024
@funky-eyes funky-eyes merged commit a24a43e into apache:2.x Apr 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

saga mode replay context lost start, issue 5682 reopen !!
4 participants