Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix postgresql sql script index name conflicts #6372

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

gao1143632516
Copy link
Contributor

In the same mode, in order to avoid the conflict of different table index names, it is best to spell the table name in the index name

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

fix the postgresql.sql index name conflicts

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

In the same mode, in order to avoid the conflict of different table index names, it is best to spell the table name in the index name
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.43%. Comparing base (a866c2d) to head (6cf132b).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6372      +/-   ##
============================================
+ Coverage     52.40%   52.43%   +0.02%     
+ Complexity     5245     5243       -2     
============================================
  Files           924      924              
  Lines         32066    32066              
  Branches       3833     3833              
============================================
+ Hits          16805    16813       +8     
+ Misses        13608    13596      -12     
- Partials       1653     1657       +4     

see 5 files with indirect coverage changes

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slievrly slievrly changed the title bugfix: The postgresql.sql index name conflicts bugfix: fix postgresql sql script index name conflicts Feb 22, 2024
@slievrly slievrly added this to the 2.1.0 milestone Feb 22, 2024
@leizhiyuan
Copy link
Contributor

@gao1143632516 need to solve conflict

@slievrly slievrly merged commit 315fd75 into apache:2.x Feb 23, 2024
6 checks passed
@slievrly
Copy link
Member

@gao1143632516 thanks for you contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants