-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix postgresql sql script index name conflicts #6372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the same mode, in order to avoid the conflict of different table index names, it is best to spell the table name in the index name
funky-eyes
reviewed
Feb 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6372 +/- ##
============================================
+ Coverage 52.40% 52.43% +0.02%
+ Complexity 5245 5243 -2
============================================
Files 924 924
Lines 32066 32066
Branches 3833 3833
============================================
+ Hits 16805 16813 +8
+ Misses 13608 13596 -12
- Partials 1653 1657 +4 |
funky-eyes
reviewed
Feb 22, 2024
slievrly
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slievrly
changed the title
bugfix: The postgresql.sql index name conflicts
bugfix: fix postgresql sql script index name conflicts
Feb 22, 2024
@gao1143632516 need to solve conflict |
@gao1143632516 thanks for you contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the same mode, in order to avoid the conflict of different table index names, it is best to spell the table name in the index name
Ⅰ. Describe what this PR did
fix the postgresql.sql index name conflicts
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews