Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: compatible with integration.grpc API #6328

Merged
merged 5 commits into from
Feb 15, 2024

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Feb 4, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

compatible with integration.grpc API

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (486f582) 51.94% compared to head (105b64d) 51.97%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6328      +/-   ##
============================================
+ Coverage     51.94%   51.97%   +0.02%     
+ Complexity     5186     5185       -1     
============================================
  Files           921      921              
  Lines         32166    32166              
  Branches       3874     3874              
============================================
+ Hits          16709    16717       +8     
+ Misses        13821    13812       -9     
- Partials       1636     1637       +1     

see 6 files with indirect coverage changes

@xingfudeshi xingfudeshi merged commit 84c9f35 into apache:2.x Feb 15, 2024
6 checks passed
@slievrly slievrly added this to the 2.1.0 milestone Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants