Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize: using namespace from command line when deployment with helm charts #6034

Merged
merged 9 commits into from
Dec 6, 2023
Merged

optimize: using namespace from command line when deployment with helm charts #6034

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
01d97be
using namespace from command line.
baiyangtx Nov 14, 2023
265679c
Merge branch '2.x' into helm-using-ns
baiyangtx Nov 21, 2023
eb11c7b
Merge branch '2.x' into helm-using-ns
funky-eyes Nov 27, 2023
503f9c3
Merge branch '2.x' into helm-using-ns
funky-eyes Dec 2, 2023
7b57ede
Merge branch '2.x' into helm-using-ns
xingfudeshi Dec 6, 2023
2009ed8
Update 2.x.md
xingfudeshi Dec 6, 2023
2501cfe
Update 2.x.md
xingfudeshi Dec 6, 2023
d782624
Update 2.x.md
xingfudeshi Dec 6, 2023
ec5b113
Update 2.x.md
xingfudeshi Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions script/server/helm/seata-server/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
apiVersion: apps/v1
kind: Deployment
metadata:
{{- if .Values.namespace }}
namespace: {{ .Values.namespace }}
{{- end}}
namespace: {{ .Release.Namespace | quote }}
name: {{ include "seata-server.name" . }}
labels:
{{ include "seata-server.labels" . | indent 4 }}
Expand Down
1 change: 1 addition & 0 deletions script/server/helm/seata-server/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
apiVersion: v1
kind: Service
metadata:
namespace: {{ .Release.Namespace | quote }}
name: {{ include "seata-server.fullname" . }}
labels:
{{ include "seata-server.labels" . | indent 4 }}
Expand Down
1 change: 1 addition & 0 deletions script/server/helm/seata-server/templates/tests/test-connection.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
apiVersion: v1
kind: Pod
metadata:
namespace: {{ .Release.Namespace | quote }}
name: "{{ include "seata-server.fullname" . }}-test-connection"
labels:
{{ include "seata-server.labels" . | indent 4 }}
Expand Down
2 changes: 0 additions & 2 deletions script/server/helm/seata-server/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
replicaCount: 1

namespace: default
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can apply namespace with command args

helm install instance  -n ${namespace}   ./seata-server

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can apply namespace with command args

helm install instance  -n ${namespace}   ./seata-server

ok


image:
repository: seataio/seata-server
tag: latest
Expand Down
Loading