-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: dubbo reference annotation failed to register transaction on tcc mode #1816
bugfix: dubbo reference annotation failed to register transaction on tcc mode #1816
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1816 +/- ##
=============================================
- Coverage 55.21% 55.09% -0.12%
+ Complexity 2518 2515 -3
=============================================
Files 446 446
Lines 14922 14941 +19
Branches 1768 1772 +4
=============================================
- Hits 8239 8232 -7
- Misses 5919 5940 +21
- Partials 764 769 +5
|
...o-alibaba/src/main/java/io/seata/integration/dubbo/alibaba/TransactionPropagationFilter.java
Outdated
Show resolved
Hide resolved
...o-alibaba/src/main/java/io/seata/integration/dubbo/alibaba/TransactionPropagationFilter.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please merge logs.
...o-alibaba/src/main/java/io/seata/integration/dubbo/alibaba/TransactionPropagationFilter.java
Outdated
Show resolved
Hide resolved
...o-alibaba/src/main/java/io/seata/integration/dubbo/alibaba/TransactionPropagationFilter.java
Outdated
Show resolved
Hide resolved
...o-alibaba/src/main/java/io/seata/integration/dubbo/alibaba/TransactionPropagationFilter.java
Outdated
Show resolved
Hide resolved
integration/dubbo/src/main/java/io/seata/integration/dubbo/TransactionPropagationFilter.java
Outdated
Show resolved
Hide resolved
integration/dubbo/src/main/java/io/seata/integration/dubbo/TransactionPropagationFilter.java
Outdated
Show resolved
Hide resolved
integration/dubbo/src/main/java/io/seata/integration/dubbo/TransactionPropagationFilter.java
Outdated
Show resolved
Hide resolved
integration/dubbo/src/main/java/io/seata/integration/dubbo/TransactionPropagationFilter.java
Outdated
Show resolved
Hide resolved
please resolve conflicts |
integration/dubbo/src/main/java/io/seata/integration/dubbo/TccReferenceAnnotationFilter.java
Outdated
Show resolved
Hide resolved
…hub.com/zhongfuhua/seata into feature_tcc_dubbo_annotation_unregister
@zhongfuhua 这个只支持了dubbo,不支持其他rpc框架,不是一个通用方案,我安排人 开发一个 通用方案吧 |
|
|
Ⅰ. Describe what this PR did
Unable to register transaction branch in TCC transaction using Dubbo annotation @reference
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Please test the springboot-tcc-sample module of seata-sample
Ⅴ. Special notes for reviews