Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: dubbo reference annotation failed to register transaction on tcc mode #1816

Conversation

zhongfuhua
Copy link
Contributor

Ⅰ. Describe what this PR did

Unable to register transaction branch in TCC transaction using Dubbo annotation @reference

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Please test the springboot-tcc-sample module of seata-sample

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Oct 24, 2019

Codecov Report

Merging #1816 into develop will decrease coverage by 0.11%.
The diff coverage is 13.04%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1816      +/-   ##
=============================================
- Coverage      55.21%   55.09%   -0.12%     
+ Complexity      2518     2515       -3     
=============================================
  Files            446      446              
  Lines          14922    14941      +19     
  Branches        1768     1772       +4     
=============================================
- Hits            8239     8232       -7     
- Misses          5919     5940      +21     
- Partials         764      769       +5
Impacted Files Coverage Δ Complexity Δ
...c/main/java/io/seata/core/context/RootContext.java 27.27% <13.04%> (-8.9%) 9 <1> (ø)
...server/store/file/FileTransactionStoreManager.java 56.5% <0%> (-1.59%) 29% <0%> (-1%)
...very/registry/zk/ZookeeperRegisterServiceImpl.java 62.9% <0%> (-0.81%) 24% <0%> (ø)
...in/java/io/seata/server/session/GlobalSession.java 84.13% <0%> (-0.49%) 67% <0%> (-1%)
...o/seata/server/coordinator/DefaultCoordinator.java 47.63% <0%> (-0.4%) 27% <0%> (-1%)

@zjinlei zjinlei added this to the 1.0 milestone Oct 24, 2019
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge logs.

@zjinlei
Copy link
Contributor

zjinlei commented Nov 12, 2019

please resolve conflicts

@slievrly slievrly changed the title TCC transaction Dubbo annotation failed to register transaction bugfix: dubbo reference annotation failed to register transaction on tcc mode Nov 13, 2019
@slievrly slievrly removed this from the 1.0 milestone Dec 12, 2019
@zjinlei zjinlei added this to the 1.1.0 milestone Jan 2, 2020
@zhangthen
Copy link
Contributor

zhangthen commented Jan 17, 2020

@zhongfuhua 这个只支持了dubbo,不支持其他rpc框架,不是一个通用方案,我安排人 开发一个 通用方案吧

@slievrly slievrly removed this from the 1.1.0 milestone Feb 5, 2020
@zjinlei zjinlei added the status: merge-conflict Category prs with merge conflict. label Mar 5, 2020
@CLAassistant
Copy link

CLAassistant commented Dec 12, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
4 out of 5 committers have signed the CLA.

✅ slievrly
✅ jsbxyyx
✅ zjinlei
✅ xingfudeshi
❌ zhongfuhua
You have signed the CLA already but the status is still pending? Let us recheck it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 5 committers have signed the CLA.

✅ xingfudeshi
❌ zhongfuhua
❌ slievrly
❌ zjinlei
❌ jsbxyyx
You have signed the CLA already but the status is still pending? Let us recheck it.

@funky-eyes
Copy link
Contributor

#5399

@funky-eyes funky-eyes closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: merge-conflict Category prs with merge conflict.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants