Skip to content
This repository was archived by the owner on Feb 8, 2019. It is now read-only.

Conversation

@wisebaldone
Copy link
Contributor

added missing api section from the old waveprotocol website.

@wisebaldone
Copy link
Contributor Author

!

@alown
Copy link
Contributor

alown commented Jan 7, 2016

The formatting looks fine, but there are a few content issues which should probably be fixed before making it part of the published documentation.

Much of this documentation refers to the "wave sandbox", which was a demo-server Google ran. There is not much use referring to this in the modern documentation anymore, though the API reference is still okay. It should be changed to simply refer to the "wave server", as it could be any of them.

There are lots of mentions of "Google Wave client", which should really refer to the "Apache Wave client", or perhaps better just "wave client", when it doesn't refer to a feature on GWave had.

The section about where to fetch the client library should be changed to say it is in the main incubator-wave repository.

It would be nicer for the history if you did an interactive rebase to remove the "merge commits" from this pull request.

Do you have your apache account yet to let you commit this yourself once it is okay?

@wisebaldone
Copy link
Contributor Author

I havnt been contacted in regards about the Apache stuff.

The proposed changes might just be added along the next scheduled patch so Ill recreate history and chuck it on the pst documentation section.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants