fix(go-client): Changed the validation logic for new configuration during queryconfig operation

go-client/pegasus/table_connector.go

@@ -283,15 +283,16 @@ func (p *pegasusTableConnector) updateConf(ctx context.Context) error {
 	return nil
 }
 
-func isPartitionValid(oldCount int, respCount int) bool {
-	return oldCount == 0 || oldCount == respCount || oldCount*2 == respCount || oldCount == respCount*2
+func isPartitionValid(respCount int) bool {
+	// Check if respCount is greater than or equal to 4 and is a power of 2
+	return respCount >= 4 && (respCount&(respCount-1)) == 0
 }
 
 func (p *pegasusTableConnector) handleQueryConfigResp(resp *replication.QueryCfgResponse) error {
 	if resp.Err.Errno != base.ERR_OK.String() {
 		return errors.New(resp.Err.Errno)
 	}
-	if resp.PartitionCount == 0 || len(resp.Partitions) != int(resp.PartitionCount) || !isPartitionValid(len(p.parts), int(resp.PartitionCount)) {
+	if resp.PartitionCount == 0 || len(resp.Partitions) != int(resp.PartitionCount) || !isPartitionValid(int(resp.PartitionCount)) {
 		return fmt.Errorf("invalid table configuration: response [%v]", resp)
 	}
 

go-client/pegasus/table_connector_test.go

@@ -447,6 +447,50 @@ func TestPegasusTableConnector_QueryConfigRespWhileCancelSplit(t *testing.T) {
 	ptb.Close()
 }
 
+func TestPegasusTableConnector_QueryConfigRespWhileTablePartitionResize(t *testing.T) {
+	// In certain scenarios, when dealing with partitions that consume excessive disk space,
+	// we may split a single partition into multiple ones (more than double the original number).
+	// To achieve this, we typically use an offline approach involving multiple splits,
+	// followed by reconstruction on another cluster. Meanwhile, we utilize metaproxy to ensure
+	// seamless traffic switching. As a result, significant changes in the partition count
+	// are possible (e.g., 8x or 1/8x the original count). Therefore, when updating the configuration,
+	// we do not require the new partition count to be related to the previous one.
+	// It only needs to be a valid number.
+
+	// Ensure loopForAutoUpdate will be closed.
+	defer leaktest.Check(t)()
+
+	client := NewClient(testingCfg)
+	defer client.Close()
+
+	tb, err := client.OpenTable(context.Background(), "temp")
+	assert.Nil(t, err)
+	defer tb.Close()
+	ptb, _ := tb.(*pegasusTableConnector)
+
+	partitionCount := len(ptb.parts)
+	resp := replication.NewQueryCfgResponse()
+	resp.Err = &base.ErrorCode{Errno: "ERR_OK"}
+	resp.AppID = ptb.appID
+	resp.PartitionCount = int32(partitionCount * 8)
+	resp.Partitions = make([]*replication.PartitionConfiguration, partitionCount*8)
+	for i := 0; i < partitionCount*8; i++ {
+		if i < partitionCount {
+			resp.Partitions[i] = ptb.parts[i].pconf
+		} else {
+			conf := replication.NewPartitionConfiguration()
+			conf.Ballot = -1
+			conf.Pid = &base.Gpid{ptb.appID, int32(i)}
+			resp.Partitions[i] = conf
+		}
+	}
+
+	err = ptb.handleQueryConfigResp(resp)
+	assert.Nil(t, err)
+	assert.Equal(t, partitionCount*8, len(ptb.parts))
+	ptb.Close()
+}
+
 func TestPegasusTableConnector_Close(t *testing.T) {
 	// Ensure loopForAutoUpdate will be closed.
 	defer leaktest.Check(t)()