fix: deal with duplication and balance race #2208
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#1589
What is changed and how does it work?
I used to use #1590 fix this bug. This method mainly achieves the purpose through delay close replica when duplication doing.
However, I later thought that this method was not smart enough, and it would cause the problem of double close replica in some cases.Although I have limited the occurrence of bugs through some logic, this logic is still fragile.
So I changed my mindset and proactively stopped dup when closing the replica.
Checklist
Tests
Code changes
What happen in Pegasus:
After this changer:
