[NEMO-385]LambdaPass, LambdaPolicy and ResourceLambdaProperty #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alapha23 Could you please rebase your branch based on the current master? |
JIRA: [NEMO-379: Change javadoc goal to a proper one](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-379) **Major changes:** - Change javadoc test command from `javadoc` to `test-javadoc`. This prevents tests from creating unwanted javdoc files, caused by apache#139 . **Minor changes to note:** - None **Tests for the changes:** - None **Other comments:** - None Closes apache#212 hihi
alapha23
force-pushed
the
LambdaExecutor
branch
from
cfbd14e
to
af63dcd
Compare
taegeonum
approved these changes
Apr 17, 2019
...src/main/java/org/apache/nemo/common/ir/vertex/executionproperty/ResourceLambdaProperty.java
Outdated
Show resolved
Hide resolved
| * Maintainer: Gao Zhiyuan<alapha23@gmail.com>. | ||
| * Resource property supporting Lambda Pass | ||
| */ | ||
| public final class ResourceLambdaProperty extends VertexExecutionProperty<ResourceLambdaProperty.Value> { |
There was a problem hiding this comment.
why don't you add a LAMBDA variable in ResourcePriorityProperty class? we don't need to create another class for the resource lambda property.
...src/main/java/org/apache/nemo/compiler/optimizer/pass/compiletime/annotating/LambdaPass.java
Outdated
Show resolved
Hide resolved
compiler/optimizer/src/main/java/org/apache/nemo/compiler/optimizer/policy/LambdaPolicy.java
Outdated
Show resolved
Hide resolved
taegeonum
requested changes
Apr 17, 2019
alapha23
force-pushed
the
LambdaExecutor
branch
from
f78ba55
to
a29c227
Compare
|
@johnyangk Could you please take a look at this PR? |
|
The PR looks good to me. 👍 |
|
@taegeonum Can you merge? (Github won't let me do it) |
taegeonum
approved these changes
Jun 7, 2019
alapha23
added a commit
to alapha23/incubator-nemo
that referenced
this pull request
Aug 2, 2019
…#214) JIRA: [NEMO-385: Support Lambda Pass with lambda policy and lambda resource property](https://issues.apache.org/jira/browse/NEMO-385) **Major changes:** - Implement LambdaPass, LambdaPolicy and ResourceLambdaProperty **Tests for the changes:** - No test suites implemented **Other comments:** - This issue is a subissue under [NEMO-352 Nemo on AWS Lambda](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-352) - This PR relates to GSoC2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: NEMO-385: Support Lambda Pass with lambda policy and lambda resource property
Major changes:
Tests for the changes:
Other comments:
Test Build Command
mvn clean && mvn install -T 2C -Dmaven.test.skip=true -Dcheckstyle.skip -Dmaven.javadoc.skip=true -Drat.skip=true -pl \!compiler/frontend/spark,\!examples/spark,\!examples/beamExecute Command