-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reject request when there is too little free memory #476
Conversation
hugegraph-api/src/main/java/com/baidu/hugegraph/api/filter/LoadDetectFilter.java
Outdated
Show resolved
Hide resolved
"will be rejected when the available memory of system " + | ||
"is lower than this value.", | ||
positiveInt(), | ||
128L |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it a suitable default value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choosed 512M, which is also the minimum memory required to start the service.
@@ -63,7 +63,7 @@ public static synchronized ServerOptions instance() { | |||
"will be rejected when the available memory of system " + | |||
"is lower than this value.", | |||
positiveInt(), | |||
128L | |||
512L |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the program is allocated with 512M memory, in general, the program itself occupies part of the memory, so it may not be unable to serve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems 256M is better
Change-Id: Ibac88733530b55d267da88e08055d71bce9b07d7
Change-Id: I6a776fc78a836bf7053ac92b222858e59a96c758
0b7615d
to
53ef577
Compare
Codecov Report
@@ Coverage Diff @@
## master #476 +/- ##
============================================
+ Coverage 69.37% 69.39% +0.01%
- Complexity 3344 3352 +8
============================================
Files 216 216
Lines 16450 16450
Branches 2352 2352
============================================
+ Hits 11413 11416 +3
- Misses 3776 3777 +1
+ Partials 1261 1257 -4
Continue to review full report at Codecov.
|
Change-Id: Ibbc1334a777e07db029ee65d7a94a249179fb96e
Change-Id: Ibac88733530b55d267da88e08055d71bce9b07d7