Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pd): translate CJK punctuations to English #2625

Merged
merged 1 commit into from
Aug 10, 2024
Merged

chore(pd): translate CJK punctuations to English #2625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions hugegraph-pd/hg-pd-client/src/main/java/org/apache/hugegraph/pd/client/PDClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1019,7 +1019,7 @@ public void changePeerList(String peerList) throws PDException {

/**
* Working mode
* Auto：If the number of partitions on each store reaches the maximum value, you need to
* Auto: If the number of partitions on each store reaches the maximum value, you need to
* specify the store group id. The store group id is 0, which is the default partition
* splitData(ClusterOp.OperationMode mode, int storeGroupId, List<ClusterOp.SplitDataParam>
* params)
Expand All @@ -1038,9 +1038,9 @@ public void splitData() throws PDException {

/**
* Working mode
* Auto：If the number of partitions on each store reaches the maximum value, you need to
* Auto: If the number of partitions on each store reaches the maximum value, you need to
* specify the store group id. The store group id is 0, which is the default partition
* Expert:Expert Mode，Specifier is required splitParams, limit SplitDataParam in the same
* Expert: Expert Mode, Specifier is required splitParams, limit SplitDataParam in the same
* store group
*
* @param mode
Expand Down Expand Up @@ -1085,11 +1085,11 @@ public void balancePartition() throws PDException {

/**
* Migrate partitions in manual mode
* //Working mode
* // Auto：Automatic transfer to the same number of partitions per Store
* // Expert:Expert Mode，Specifier is required transferParams
* // Working mode
* // Auto: Automatic transfer to the same number of partitions per Store
* // Expert: Expert Mode, Specifier is required transferParams
*
* @param params Designation transferParams, expert mode，request source store / target store
* @param params Designation transferParams, expert mode, request source store / target store
* in the same store group
* @throws PDException
*/
Expand Down Expand Up @@ -1228,7 +1228,7 @@ public void deleteShardGroup(int groupId) throws PDException {
* Used for the store's shard list rebuild
*
* @param groupId shard group id
* @param shards shard list，delete when shards size is 0
* @param shards shard list, delete when shards size is 0
*/
public void updateShardGroupOp(int groupId, List<Metapb.Shard> shards) throws PDException {
Pdpb.ChangeShardRequest request = Pdpb.ChangeShardRequest.newBuilder()
Expand Down
22 changes: 11 additions & 11 deletions hugegraph-pd/hg-pd-core/src/main/java/org/apache/hugegraph/pd/PartitionService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@
partition, 0))
.build();
log.debug(
"{} Partition get code = {}, partition id = {}, start = {}, end = {}， leader = {}",
"{} Partition get code = {}, partition id = {}, start = {}, end = {}, leader = {}",
graphName, (code), partition.getId(), partition.getStartKey(),
partition.getEndKey(), partShard.getLeader());

Expand Down Expand Up @@ -264,7 +264,7 @@
}

/**
* compute graph partition id。partition gap * store group id + offset
* compute graph partition id, partition gap * store group id + offset
*
* @param graph graph
* @param offset offset
Expand Down Expand Up @@ -764,7 +764,7 @@
}

/**
* transfer leader to other shard 。
* transfer leader to other shard
* Just transfer a partition
*/
public void transferLeader(Integer partId, Metapb.Shard shard) {
Expand Down Expand Up @@ -862,7 +862,7 @@

var groupSize = partitions.size() / toCount; // merge group size
// 0~12 to 4 partitions
// scheme：0,1,2 => 0, 3,4,5 -> 1, 6,7,8 ->2, 9,10,11 -> 3
// scheme: 0,1,2 => 0, 3,4,5 => 1, 6,7,8 => 2, 9,10,11 => 3
// Ensure the continuity of partitions
for (int i = 0; i < toCount; i++) {
var startKey = partitions.get(i * groupSize).getStartKey();
Expand Down Expand Up @@ -1010,7 +1010,7 @@
*/
protected void fireChangeShard(Metapb.Partition partition, List<Metapb.Shard> shards,
ConfChangeType changeType) {
log.info("fireChangeShard partition: {}-{}， changeType:{} {}", partition.getGraphName(),
log.info("fireChangeShard partition: {}-{}, changeType: {} {}", partition.getGraphName(),

Check warning on line 1013 in hugegraph-pd/hg-pd-core/src/main/java/org/apache/hugegraph/pd/PartitionService.java

View check run for this annotation

Codecov / codecov/patch

hugegraph-pd/hg-pd-core/src/main/java/org/apache/hugegraph/pd/PartitionService.java#L1013 

Added line #L1013 was not covered by tests
partition.getId(), changeType, shards);
instructionListeners.forEach(cmd -> {
try {
Expand All @@ -1037,7 +1037,7 @@
* @param partition
*/
protected void fireSplitPartition(Metapb.Partition partition, SplitPartition splitPartition) {
log.info("fireSplitPartition partition: {}-{}， split :{}",
log.info("fireSplitPartition partition: {}-{}, split: {}",

Check warning on line 1040 in hugegraph-pd/hg-pd-core/src/main/java/org/apache/hugegraph/pd/PartitionService.java

View check run for this annotation

Codecov / codecov/patch

hugegraph-pd/hg-pd-core/src/main/java/org/apache/hugegraph/pd/PartitionService.java#L1040 

Added line #L1040 was not covered by tests
partition.getGraphName(), partition.getId(), splitPartition);
instructionListeners.forEach(cmd -> {
try {
Expand All @@ -1052,7 +1052,7 @@
* Send a Leader Switchover message
*/
protected void fireTransferLeader(Metapb.Partition partition, TransferLeader transferLeader) {
log.info("fireTransferLeader partition: {}-{}， leader :{}",
log.info("fireTransferLeader partition: {}-{}, leader: {}",

Check warning on line 1055 in hugegraph-pd/hg-pd-core/src/main/java/org/apache/hugegraph/pd/PartitionService.java

View check run for this annotation

Codecov / codecov/patch

hugegraph-pd/hg-pd-core/src/main/java/org/apache/hugegraph/pd/PartitionService.java#L1055 

Added line #L1055 was not covered by tests
partition.getGraphName(), partition.getId(), transferLeader);
instructionListeners.forEach(cmd -> {
try {
Expand All @@ -1067,7 +1067,7 @@
* Send a message to the partition to move data
*
* @param partition Original partition
* @param movePartition Target partition，contains key range
* @param movePartition Target partition, contains key range
*/
protected void fireMovePartition(Metapb.Partition partition, MovePartition movePartition) {
log.info("fireMovePartition partition: {} -> {}",
Expand Down Expand Up @@ -1159,8 +1159,8 @@
/**
* When all migration subtasks succeed:
* 1. Send cleanup source partition directives
* 2. Set up target online，renewal key range, renewal graph partition count
* 3. delete move task，mission ended
* 2. Set up target online, renewal key range, renewal graph partition count
* 3. delete move task, mission ended
*
* @param subTasks all move sub tasks
* @param graphName graph name
Expand Down Expand Up @@ -1238,7 +1238,7 @@
fireCleanPartition(source, cleanPartition);
}

// renewal key range, Local updates，client renewal
// renewal key range, Local updates, client renewal
// updatePartition(targetPartitions);

// renewal target Partition status, source may be deleted, so do not process
Expand Down
2 changes: 1 addition & 1 deletion hugegraph-pd/hg-pd-core/src/main/java/org/apache/hugegraph/pd/StoreNodeService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,7 @@ public synchronized List<Metapb.Shard> reallocShards(Metapb.ShardGroup shardGrou
}

/**
* According to the number of partitions，distribute group shard
* According to the number of partitions, distribute group shard
*
* @param groups list of (partition id, count)
* @return total groups
Expand Down
Loading