chore: delete binary license file

hugegraph-pd/hg-pd-dist/src/assembly/static/bin/start-hugegraph-pd.sh

@@ -62,7 +62,7 @@ PID_FILE="$BIN/pid"
 ensure_path_writable "$LOGS"
 ensure_path_writable "$PLUGINS"
 
-# The maximum and minium heap memory that service can use
+# The maximum and minimum heap memory that service can use
 MAX_MEM=$((32 * 1024))
 MIN_MEM=$((1 * 512))
 EXPECT_JDK_VERSION=11

hugegraph-pd/hg-pd-dist/src/assembly/static/bin/stop-hugegraph-pd.sh

@@ -40,7 +40,7 @@ if [ ! -f ${PID_FILE} ]; then
     exit 0
 fi
 
-PID=`cat $PID_FILE`
+PID=$(cat $PID_FILE)
 kill_process_and_wait "HugeGraphPDServer" "$PID" "$SERVER_SHUTDOWN_TIMEOUT_S"
 
 if [ $? -eq 0 ]; then

hugegraph-pd/hg-pd-dist/src/assembly/static/bin/util.sh

@@ -17,6 +17,7 @@
 # limitations under the License.
 #
 
+# TODO: consider reuse it with server-dist module (almost same as it)
 function command_available() {
     local cmd=$1
     if [ $(command -v $cmd >/dev/null 2>&1) ]; then
@@ -31,7 +32,7 @@ function read_property() {
     # file path
     file_name=$1
     # replace "." to "\."
-    property_name=`echo $2 | sed 's/\./\\\./g'`
+    property_name=$(echo $2 | sed 's/\./\\\./g')
     cat $file_name | sed -n -e "s/^[ ]*//g;/^#/d;s/^$property_name=//p" | tail -1
 }
 
@@ -40,7 +41,7 @@ function write_property() {
     local key=$2
     local value=$3
 
-    local os=`uname`
+    local os=$(uname)
     case $os in
         # Note: in mac os should use sed -i '' "xxx" to replace string,
         # otherwise prompt 'command c expects \ followed by text'.

hugegraph-pd/hg-pd-dist/src/assembly/static/conf/application.yml

@@ -31,6 +31,7 @@ management:
 
 logging:
   config: 'file:./conf/log4j2.xml'
+# TODO: handle the license file later (PDConfig)
 license:
   verify-path: ./conf/verify-license.json
   license-path: ./conf/hugegraph.license

hugegraph-pd/hg-pd-dist/src/assembly/static/conf/log4j2.xml

@@ -89,7 +89,7 @@
                                  filePattern="${LOG_PATH}/$${date:yyyy-MM}/audit-${FILE_NAME}-%d{yyyy-MM-dd-HH}-%i.gz"
                                  bufferedIO="true" bufferSize="524288" immediateFlush="false">
             <ThresholdFilter level="TRACE" onMatch="ACCEPT" onMismatch="DENY" />
-            <!-- Use simple format for audit log to speed up -->
+            <!-- Use a simple format for audit log to speed up -->
             <!-- PatternLayout pattern="%-d{yyyy-MM-dd HH:mm:ss} - %m%n"/ -->
             <JsonLayout compact="true" eventEol="true" locationInfo="true">
                 <KeyValuePair key="timestamp" value="$${date:yyyy-MM-dd HH:mm:ss.SSS}" />

hugegraph-pd/hg-pd-service/src/main/java/org/apache/hugegraph/pd/service/PDService.java

@@ -1347,6 +1347,7 @@ public void balanceLeaders(Pdpb.BalanceLeadersRequest request,
         observer.onCompleted();
     }
 
+    // TODO: keep it now & clean it later
     @Override
     public void putLicense(PutLicenseRequest request,
                            StreamObserver<PutLicenseResponse> responseObserver) {
@@ -1366,12 +1367,12 @@ public void putLicense(PutLicenseRequest request,
             }
             FileUtils.writeByteArrayToFile(licenseFile, content, false);
         } catch (Exception e) {
-            log.error("putLicense with error: {}", e);
+            log.error("putLicense with error:", e);
             if (moved) {
                 try {
                     FileUtils.moveFile(bakFile, licenseFile);
                 } catch (IOException ex) {
-                    log.error("failed to restore the license file.{}", ex);
+                    log.error("failed to restore the license file:", ex);
                 }
             }
             Pdpb.ResponseHeader header =