Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect use of 'NO_LIMIT' variable #2253

Merged
merged 1 commit into from
Jul 23, 2023

Conversation

DanGuge
Copy link
Contributor

@DanGuge DanGuge commented Jul 21, 2023

  • replace Query.NO_LIMIT with HugeTraverser.NO_LIMIT

Purpose of the PR

  • fix the incorrect use of 'NO_LIMIT' variable

Main Changes

  • replace Query.NO_LIMIT with HugeTraverser.NO_LIMIT in KoutAPI.java, KoutRecords.java, KneighborAPI.java and KneighborRecords.java
  • format KoutAPI.java, KoutRecords.java, KneighborAPI.java and KneighborRecords.java based on hugegraph-style

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

* replace Query.NO_LIMIT with HugeTraverser.NO_LIMIT
@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Merging #2253 (e3ae330) into master (7927335) will increase coverage by 6.94%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #2253      +/-   ##
============================================
+ Coverage     58.08%   65.03%   +6.94%     
- Complexity      905      977      +72     
============================================
  Files           498      498              
  Lines         40684    40684              
  Branches       5681     5681              
============================================
+ Hits          23632    26459    +2827     
+ Misses        14613    11600    -3013     
- Partials       2439     2625     +186     
Impacted Files Coverage Δ
.../apache/hugegraph/api/traversers/KneighborAPI.java 74.50% <0.00%> (ø)
...a/org/apache/hugegraph/api/traversers/KoutAPI.java 75.00% <0.00%> (ø)
.../traversal/algorithm/records/KneighborRecords.java 89.47% <0.00%> (ø)
...graph/traversal/algorithm/records/KoutRecords.java 85.71% <0.00%> (ø)

... and 104 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@javeme javeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@imbajin imbajin merged commit b02c2bd into apache:master Jul 23, 2023
@DanGuge DanGuge deleted the fix_no_limit branch July 28, 2023 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants