Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump up rocksdb version to 6.22 #1742

Merged
merged 6 commits into from
Jun 7, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
comment siged delete-range key test due to rocksdb issue #8239
Change-Id: I3827d6229ce877fd251d1b0b76219318b53bb542
  • Loading branch information
javeme committed Jun 2, 2022
commit b50dd6ee02ba3d033610351cbe583ab5d2c072cd
Original file line number Diff line number Diff line change
Expand Up @@ -519,9 +519,19 @@ public void testDeleteByRangeWithSignedBytes() throws RocksDBException {
byte[] value21 = getBytes("value-2-1");
session.put(TABLE, key21, value21);

session.deleteRange(TABLE, new byte[]{1, -3}, new byte[]{1, 3});
this.commit();

// TODO: enable after fixed rocksdb issue #8239
/*
session.deleteRange(TABLE, new byte[]{1, -3}, new byte[]{1, 3});
Assert.assertThrows(BackendException.class, () -> {
this.commit();
}, e -> {
Assert.assertContains("end key comes before start key",
e.getCause().getMessage());
});
*/

Assert.assertArrayEquals(value11, session.get(TABLE, key11));
Assert.assertArrayEquals(value12, session.get(TABLE, key12));
Assert.assertArrayEquals(value21, session.get(TABLE, key21));
Expand Down