-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ScyllaDB: lost page results due to not fetched the entire page #1407
Conversation
fix #1340 Change-Id: Ib89d9790af4236a137d9215e27f0d17f0de10afd
why set remaining = getAvailableWithoutFetching(): https://support.datastax.com/hc/en-us/articles/115003076346-FAQ-Why-does-Java-driver-setFetchSize-return-all-rows- |
ci error of cassandra backend:
It's ok after retry. seems the reason is: current testAddEdgeWithTtlAndTtlStartTime use the timestamp of the previous test case used. |
Codecov Report
@@ Coverage Diff @@
## master #1407 +/- ##
============================================
+ Coverage 61.89% 62.22% +0.33%
- Complexity 5811 5857 +46
============================================
Files 386 381 -5
Lines 32192 32135 -57
Branches 4497 4504 +7
============================================
+ Hits 19924 19995 +71
+ Misses 10230 10089 -141
- Partials 2038 2051 +13 Continue to review full report at Codecov.
|
TODO: ensure return the full page to users which scylla fetched to local. |
Change-Id: Ife31d04509c1815793b07badc101bde27ba1299c
@@ -72,6 +72,7 @@ public String toString() { | |||
} | |||
|
|||
public static PageState fromString(String page) { | |||
E.checkNotNull("page", "page"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E.checkNotNull(page, "page");
Change-Id: I8abe05cbdc95c28bc384e73d554a30300042f3bb
fix #1340
Change-Id: Ib89d9790af4236a137d9215e27f0d17f0de10afd