Skip to content

fix: release shell & enhance code (#220) #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Conversation

coderzc
Copy link
Member

@coderzc coderzc commented Dec 18, 2022

  • fix release shell
  • chore: print hash in script and exit if upload failed

Co-authored-by: imbajin jin@apache.org
(cherry picked from commit 550c4b8)

* fix release shell
* chore: print hash in script and exit if upload failed

Co-authored-by: imbajin <jin@apache.org>
(cherry picked from commit 550c4b8)
@coderzc coderzc requested a review from imbajin December 18, 2022 15:45
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could cherry pick it directly next time (pr is not required)

@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Merging #221 (1aa3ed7) into release-1.0.0 (dd1f82e) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##             release-1.0.0     #221      +/-   ##
===================================================
- Coverage            85.81%   85.79%   -0.03%     
+ Complexity            3233     3231       -2     
===================================================
  Files                  344      344              
  Lines                12079    12079              
  Branches              1087     1087              
===================================================
- Hits                 10366    10363       -3     
- Misses                1188     1189       +1     
- Partials               525      527       +2     
Impacted Files Coverage Δ
...raph/computer/k8s/operator/OperatorEntrypoint.java 85.71% <0.00%> (-2.53%) ⬇️
...mputer/k8s/operator/common/AbstractController.java 84.54% <0.00%> (-0.97%) ⬇️
...k8s/operator/controller/ComputerJobController.java 89.72% <0.00%> (-0.35%) ⬇️
...rg/apache/hugegraph/computer/core/bsp/BspBase.java 100.00% <0.00%> (+7.69%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@coderzc
Copy link
Member Author

coderzc commented Dec 19, 2022

could cherry pick it directly next time (pr is not required)

It seems that there is no permission.

@imbajin
Copy link
Member

imbajin commented Dec 19, 2022

could cherry pick it directly next time (pr is not required)

It seems that there is no permission.

refer https://issues.apache.org/jira/browse/INFRA-23885

@coderzc coderzc requested a review from javeme December 21, 2022 02:35
@zyxxoo zyxxoo merged commit b492010 into release-1.0.0 Dec 22, 2022
@zyxxoo zyxxoo deleted the fix_release_shell branch December 22, 2022 03:23
imbajin added a commit that referenced this pull request Feb 10, 2023
* fix: release shell & enhance code (#220) (#221)

* Create NOTICE (#223)

---------

Co-authored-by: Cong Zhao <zhaocong@apache.org>
Co-authored-by: Simon Cheung <ming@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants