Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] fallback unsupported orc write for spark32 and spark33 #7996

Merged

Conversation

jackylee-ch
Copy link
Contributor

@jackylee-ch jackylee-ch commented Nov 19, 2024

I have run bellow sqls failed with footer parse while reading orc file. After look inside, I found the file is written with parquet, not orc, and we haven't support the orc write now.

CREATE TABLE t (c int) USING ORC;
INSERT OVERWRITE TABLE t SELECT 1 as c;
select * from t;

@jackylee-ch jackylee-ch marked this pull request as draft November 19, 2024 16:40
@github-actions github-actions bot added the VELOX label Nov 19, 2024
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@jackylee-ch jackylee-ch changed the title [VL][Test] Remove unsupported orc write for spark 3.2, 3.3 [VL] fallback unsupported orc write for spark32 and spark33 Nov 20, 2024
@jackylee-ch jackylee-ch marked this pull request as ready for review November 20, 2024 06:09
@jackylee-ch
Copy link
Contributor Author

cc @PHILO-HE

@PHILO-HE
Copy link
Contributor

I'm not sure about this. Could you add some description? It has no impact on other Spark versions?

@jackylee-ch
Copy link
Contributor Author

I'm not sure about this. Could you add some description?

Sure, I would update the pr description.

It has no impact on other Spark versions?

For spark32 and spark33, we use GlutenWriterColumnarRules to check the supported fileformats. But for spark34 and spark35, we use BackendsApiManager.getSettings.supportWriteFilesExec to check the supported file formats. Hense this won't impact other spark versions.

Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JkSelf, please confirm. the changes.

Copy link
Contributor

@JkSelf JkSelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your fix. LGTM.

@jackylee-ch jackylee-ch merged commit 7a564d8 into apache:main Nov 21, 2024
46 checks passed
@jackylee-ch jackylee-ch deleted the wip_remove_unsupported_orc_write branch November 21, 2024 02:10
@JkSelf JkSelf mentioned this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants