[GLUTEN-7600][VL] Prepare test case for the removal of workaround code for empty schema batches #7601
+66
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
zhztheplayer
commented
Oct 21, 2024
Comment on lines
+927
to
+932
| val filePath = rootPath + "/datasource/csv/student.csv" | ||
| val df = spark.read | ||
| .format("csv") | ||
| .option("header", "true") | ||
| .load(filePath) | ||
| df.createOrReplaceTempView("student") |
There was a problem hiding this comment.
nit: The table creation code is duplicated in different cases. Refactor required.
JkSelf
approved these changes
Oct 21, 2024
|
Run Gluten Clickhouse CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7600
Add a unit test to guard against the removal of special handling code in query planner for empty schema batches. E.g.,
EmptySchemaWorkaroundandOffloadHashAggregate.Also with some code cleanups against some other unrelated PRs recently merged to main.