[GLUTEN-7532][CORE] Rewrite TakeOrderedAndProject with actually executed operators when do offload #7533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI |
|
+1 to the idea. I remember there was vanilla Spark limitation as blocker against a similar effort. But let's see if it's doable at this time. |
|
Run Gluten Clickhouse CI |
1 similar comment
|
Run Gluten Clickhouse CI |
ivoson
force-pushed
the
rewrite-takeorderedproject
branch
from
43b02cf
to
b58b47e
Compare
|
Run Gluten Clickhouse CI |
ivoson
force-pushed
the
rewrite-takeorderedproject
branch
from
b58b47e
to
bc11814
Compare
|
Run Gluten Clickhouse CI |
|
cc @zhztheplayer can you please review this PR? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Rewrite the
TakeOrderedAndProjectExecTransformerto the operators which are actually executed when do offload. Currently, the logic is wrapped in theRDDof the operator. Which means that in the RDD computation we play with the sql operators to generate newRDDs which is not a common practice processing sql queries. And the final executed plan and metrics information won't be shown correctly in the Spark UI page.In this PR, rewrite the node
TakeOrderedAndProjectExecTransformerwhen do offload so that the operators can be shown correctly.How was this patch tested?
UT