Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLUTEN-7307][VL] Update openssl version in velox setup for centos9 #7308

Merged
merged 6 commits into from
Oct 1, 2024
Merged

[GLUTEN-7307][VL] Update openssl version in velox setup for centos9 #7308

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
75250b2
update openssl version
Sep 14, 2024
cc6b5bf
Merge branch 'apache:main' into update_openssl_version
Sep 22, 2024
539ede0
Merge branch 'apache:main' into update_openssl_version
pratham76 Sep 26, 2024
bbb502d
mv install to
Sep 26, 2024
8cb8cda
fix
Sep 26, 2024
d8381ce
create subshell for change dir
Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ep/build-velox/src/get_velox.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ function process_setup_centos9 {
sed -i '/^.*dnf_install autoconf/a\ dnf_install libxml2-devel libgsasl-devel libuuid-devel' scripts/setup-centos9.sh

ensure_pattern_matched 'install_gflags' scripts/setup-centos9.sh
sed -i '/^function install_gflags.*/i function install_openssl {\n wget_and_untar https://github.com/openssl/openssl/archive/refs/tags/OpenSSL_1_1_1s.tar.gz openssl \n cd openssl \n ./config no-shared && make depend && make && sudo make install \n cd ..\n}\n' scripts/setup-centos9.sh
sed -i '/^function install_gflags.*/i function install_openssl {\n wget_and_untar https://github.com/openssl/openssl/releases/download/openssl-3.2.2/openssl-3.2.2.tar.gz openssl \n cd ${DEPENDENCY_DIR}/openssl \n ./config no-shared && make depend && make && sudo make install \n}\n' scripts/setup-centos9.sh
Copy link
Contributor

@majetideepak majetideepak Sep 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to use curly braces if you want to cd in a subshell and avoid cd ../..
( cd ${DEPENDENCY_DIR}/openssl \n ./config no-shared && make depend && make && sudo make install )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated. Will keep this in mind

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@majetideepak please review and lmk if any more changes are required. Thanks.


ensure_pattern_matched 'install_fbthrift' scripts/setup-centos9.sh
sed -i '/^ run_and_time install_fbthrift/a \ run_and_time install_openssl' scripts/setup-centos9.sh
Expand Down