Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLUTEN-6387][CH] support percentile function #6396

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

[GLUTEN-6387][CH] support percentile function #6396

wants to merge 9 commits into from
+392 −164

Conversation

taiyang-li
Copy link
Contributor

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

(Fixes: #6387)

image

image

@taiyang-li taiyang-li marked this pull request as draft July 10, 2024 10:35
@github-actions GitHub Actions
Copy link

#6387

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

1 similar comment
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@taiyang-li taiyang-li marked this pull request as ready for review July 11, 2024 02:37
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

PHILO-HE
PHILO-HE previously approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reviewed core/velox module code. Looks nice! Thanks!

@exmy
Copy link
Contributor

exmy commented Jul 11, 2024

It seems missing PercentileSuite in Spark ut. Could you help add this suite?

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@taiyang-li
Copy link
Contributor Author

It seems missing PercentileSuite in Spark ut. Could you help add this suite?

done

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@taiyang-li
Copy link
Contributor Author

failed ut can't be reproduced using spark-sql

"Support filter clause for aggregate function uses SortAggregateExec"

set  spark.sql.execution.useObjectHashAggregateExec = false;
CREATE TABLE testData2 (a INT, b INT);
INSERT INTO testData2 VALUES (1, 1), (1, 2), (2, 1), (2, 2), (3, 1), (3, 2);
SELECT PERCENTILE(a, 1) FILTER (WHERE b > 1) FROM testData2

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@taiyang-li taiyang-li marked this pull request as draft July 22, 2024 02:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale stale label Sep 6, 2024
@github-actions GitHub Actions
Copy link

This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks.

@github-actions github-actions bot closed this Sep 16, 2024
@taiyang-li taiyang-li reopened this Sep 16, 2024
@github-actions github-actions bot added CORE works for Gluten Core VELOX CLICKHOUSE labels Sep 16, 2024
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@github-actions github-actions bot removed the stale stale label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PHILO-HE PHILO-HE PHILO-HE left review comments

@lgbo-ustc lgbo-ustc Awaiting requested review from lgbo-ustc

@exmy exmy Awaiting requested review from exmy

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLICKHOUSE CORE works for Gluten Core VELOX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CH] support aggregate function percentile
3 participants
@taiyang-li @exmy @PHILO-HE