[GLUTEN-4999] Fix ColumnarUnionExec to get PartitionerAwareUnionRDD used if child RDDs share same partitioner #5021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etter to be transformed to PartitionerAwareUnionRDD than UnionRDD when they has same partitioner
|
Run Gluten Clickhouse CI |
|
thank you for this fix, I have verified Gluten's union rdd is same as Spark's after this pr. Spark Gluten before Gluten after please refine pr title more clearly. |
Yohahaha
approved these changes
Mar 20, 2024
PHILO-HE
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…etter to be transformed to PartitionerAwareUnionRDD than UnionRDD when they has same partitioner. #4999
What changes were proposed in this pull request?
For example:
select * from test a
union all
select * from test b
union all
select * from test c
They have the same partitioner.
In ColumnarUnionExec, they will be transformed to rdd1.union(rdd2).union(rdd3).
After this pr,
In ColumnarUnionExec, they will be transformed to PartitionerAwareUnionRDD(sc, Seq(rdd1, rdd2, rdd3)) if they have the same partitioner.
(Fixes: #4999)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)