Add support for nested types, geoparquet groups, and postgres jsonb in data table

[bchapuis]

No description provided.

[Drabble]

It looks good, I just added two comments.

[Drabble]

When an optional field or a group is null in the geoparquet file, this will raise an exception. The same thing happens in the asRowValues method. I tested it with real Overture data.

[bchapuis]

This is a good point. I'm not a fan of returning Optional everywhere, but this is something we could consider. Another option could be to return null and let the user check for it.

@Drabble @sebr72 Which variant do you prefer?

[sebr72]

@bchapuis My instinct would say that when a field is optional we use Optional. This way we can make a difference (in the way our code explains it) with fields which are not optional with a null value.

[bchapuis]

@sebr72 The problem is that we also need to return Optional for each values in a potentially very big geoparquet file. As for the List, I'm a bit worried about the overhead. It also means that we need to return Optional for required values.

Here are some interesting arguments for and against the use of Optional:
https://blogs.oracle.com/javamagazine/post/optional-class-null-pointer-drawbacks

[sebr72]

@bchapuis based on the article and your concern about the overhead, I am happy if we don't use Optional.

[sonarqubecloud]

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint