Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sonar cleanups #858

Merged
merged 11 commits into from
May 31, 2024
Merged

Sonar cleanups #858

merged 11 commits into from
May 31, 2024

Conversation

sebr72
Copy link
Contributor

@sebr72 sebr72 commented May 30, 2024

No description provided.

@sebr72 sebr72 force-pushed the 849-sonar-cleanup branch from b67d4c5 to dd93ea0 Compare May 30, 2024 20:19
github-advanced-security[bot]
github-advanced-security bot found potential problems May 30, 2024
View reviewed changes
baremaps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/GeoParquetReader.java
long recordCount;
MessageType messageType;
Map<String, String> keyValueMetadata;
try (ParquetFileReader reader = ParquetFileReader.open(configuration, file.getPath())) {

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
ParquetFileReader.open
Loading
should be avoided because it has been deprecated.
@sebr72 sebr72 force-pushed the 849-sonar-cleanup branch from 2d2fd52 to da83ad6 Compare May 30, 2024 22:59
@sebr72 sebr72 force-pushed the 849-sonar-cleanup branch from da83ad6 to 92e7a4d Compare May 30, 2024 23:03
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sebr72 sebr72 marked this pull request as ready for review May 31, 2024 00:26
@bchapuis bchapuis self-requested a review May 31, 2024 07:48
bchapuis
bchapuis approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@bchapuis bchapuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you! I will merge this PR. I suggest we don't use System.out.println in unit tests in the future. I forgot to remove the one in GeoParquetReaderTest before merging my previous PR.

...ps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/hadoop/GeoParquetGroupWriter.java Show resolved Hide resolved
baremaps-geoparquet/src/test/java/org/apache/baremaps/geoparquet/GeoParquetReaderTest.java Show resolved Hide resolved
@bchapuis bchapuis merged commit db7ef92 into apache:main May 31, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bchapuis bchapuis bchapuis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebr72 @bchapuis