Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add importer plugin type #1122

Merged
merged 5 commits into from
Oct 16, 2024
Merged

Add importer plugin type #1122

merged 5 commits into from
Oct 16, 2024

Conversation

Anan1225
Copy link
Contributor

OSPP Project

  1. To realize add questions from Slack Slash Command, add a new plugin type importer.
  2. Main function: get question detail from Client Response, then directly add question to Answer.

see issue 151 and plugin user-center-slack

@LinkinStars LinkinStars self-requested a review September 29, 2024 03:03
@LinkinStars LinkinStars self-assigned this Sep 29, 2024
LinkinStars
LinkinStars requested changes Sep 30, 2024
View reviewed changes
plugin/importer.go Outdated Show resolved Hide resolved
internal/router/plugin_api_router.go Outdated Show resolved Hide resolved
LinkinStars
LinkinStars reviewed Oct 15, 2024
View reviewed changes
plugin/importer.go Outdated Show resolved Hide resolved
LinkinStars
LinkinStars requested changes Oct 16, 2024
View reviewed changes
internal/service/plugin_common/plugin_common_service.go Outdated Show resolved Hide resolved
internal/service/importer/importer_service.go Outdated Show resolved Hide resolved
internal/service/importer/importer_service.go Outdated Show resolved Hide resolved
@LinkinStars LinkinStars self-requested a review October 16, 2024 03:26
@LinkinStars LinkinStars changed the base branch from main to dev October 16, 2024 03:27
LinkinStars
LinkinStars approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@LinkinStars LinkinStars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice plugin type design that can be expanded with more features later. LGTM.

@LinkinStars LinkinStars merged commit 1e82b04 into apache:dev Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinkinStars LinkinStars LinkinStars approved these changes

Assignees

@LinkinStars LinkinStars

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anan1225 @LinkinStars