Add importer plugin type #1122
Open
Add importer plugin type #1122
+274
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinkinStars
requested changes
Sep 30, 2024
Comment on lines
+31
to
+34
| type Importer interface { | ||
| Base | ||
| GetQuestion(ctx *gin.Context) (questionInfo *QuestionImporterInfo, err error) | ||
| } |
There was a problem hiding this comment.
The Importer interface should be designed primarily for importing data. It is also designed for expansion later. So it should accept the Q&A data directly and add it to the database. May like this
type Importer interface {
Base
RegisterImporter(importer QuestionImporter)
}
type QuestionImporter interface {
AddQuestions(questions *QuestionInfo) (err error)
}FYI:
incubator-answer/plugin/search.go
Line 106 in 8e6fa13
| @@ -68,6 +70,9 @@ func (pr *PluginAPIRouter) RegisterUnAuthConnectorRouter(r *gin.RouterGroup) { | |||
| r.GET("/captcha/config", pr.captchaController.GetCaptchaConfig) | |||
| r.GET("/embed/config", pr.embedController.GetEmbedConfig) | |||
| r.GET("/render/config", pr.renderController.GetRenderConfig) | |||
|
|
|||
| // importer plugin | |||
| r.POST("/importer/answer", pr.importerController.ImportCommand) | |||
There was a problem hiding this comment.
Based on the design of the interface, it is clear that there is a problem here. The API exposed here is not authenticated, which means that any user can use this interface to add data, which is unsafe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSPP Project
see issue 151 and plugin user-center-slack