IGNITE-7986: GridPartitionStateMap.entrySet() optimization. #3659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dspavlov
reviewed
May 3, 2018
|
|
||
| cur = next; | ||
| next++; | ||
| cur = idx / BITS; |
There was a problem hiding this comment.
I suggest to document how it works. It is not totally clear to me after reading the code what is done below
dspavlov
reviewed
May 3, 2018
|
|
||
| assertNotNull(entry1.getValue()); | ||
| assertNotNull(entry2.getValue()); | ||
| assertNotEquals(entry1.getKey(), entry2.getKey()); |
There was a problem hiding this comment.
I suggest to add space before sematic block
dspavlov
reviewed
May 3, 2018
| } | ||
|
|
||
| /** | ||
| * |
There was a problem hiding this comment.
Could you please document what test does and what is expected.
dspavlov
reviewed
May 3, 2018
|
|
||
| return new Iterator<Entry<Integer, GridDhtPartitionState>>() { | ||
| private int next; | ||
| private int idx; |
There was a problem hiding this comment.
please add javadoc for this and other fields
dspavlov
reviewed
May 3, 2018
| private int idx; | ||
| private int cur; | ||
|
|
||
| @Override public boolean hasNext() { |
There was a problem hiding this comment.
Looks like has next called twice will change iterarot state
macrergate
pushed a commit
to gridgain/apache-ignite
that referenced
this pull request
Oct 16, 2018
…ache#3659. Signed-off-by: dpavlov <dpavlov@apache.org> (cherry picked from commit bc7814e)
antonovsergey93
pushed a commit
to gridgain/apache-ignite
that referenced
this pull request
Aug 25, 2019
…ache#3659. Signed-off-by: dpavlov <dpavlov@apache.org> (cherry picked from commit bc7814e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.