IGNITE-18372 metrics for k2i consumer #277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/metrics/KafkaToIgniteMetrics.java
Outdated
Show resolved
Hide resolved
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/metrics/KafkaToIgniteMetrics.java
Outdated
Show resolved
Hide resolved
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/AbstractIgniteCdcStreamer.java
Outdated
Show resolved
Hide resolved
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/kafka/KafkaToIgniteCdcStreamerApplier.java
Outdated
Show resolved
Hide resolved
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/kafka/KafkaToIgniteClientCdcStreamer.java
Outdated
Show resolved
Hide resolved
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/metrics/KafkaToIgniteMetrics.java
Outdated
Show resolved
Hide resolved
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/metrics/KafkaToIgniteMetrics.java
Outdated
Show resolved
Hide resolved
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/metrics/KafkaToIgniteMetrics.java
Outdated
Show resolved
Hide resolved
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/AbstractIgniteCdcStreamer.java
Outdated
Show resolved
Hide resolved
...cdc-ext/src/main/java/org/apache/ignite/cdc/kafka/KafkaToIgniteCdcStreamerConfiguration.java
Outdated
Show resolved
Hide resolved
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/kafka/KafkaToIgniteMetrics.java
Outdated
Show resolved
Hide resolved
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/kafka/KafkaToIgniteMetrics.java
Outdated
Show resolved
Hide resolved
modules/cdc-ext/src/test/java/org/apache/ignite/cdc/kafka/CdcKafkaReplicationTest.java
Outdated
Show resolved
Hide resolved
modules/cdc-ext/src/test/java/org/apache/ignite/cdc/kafka/CdcKafkaReplicationTest.java
Outdated
Show resolved
Hide resolved
modules/cdc-ext/src/test/java/org/apache/ignite/cdc/kafka/CdcKafkaReplicationTest.java
Outdated
Show resolved
Hide resolved
modules/cdc-ext/src/test/java/org/apache/ignite/cdc/AbstractReplicationTest.java
Outdated
Show resolved
Hide resolved
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/kafka/KafkaToIgniteMetrics.java
Outdated
Show resolved
Hide resolved
added 12 commits
July 15, 2024 11:29
* Standalone context fixed * Metrics description corrected * Metrics count fixed * Minor fixes
* received events metrics fixed
* Code style fixes * Constants naming fixed * Documentation
* variable naming fixed
* streamer naming fixed
* metric spi register fix
* metric spi register fix
* CdcKafkaReplicationAppsTest fix
alex-plekhanov
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metrics for CDC with Kafka
CDC with Kafka doesn't have metrics for 'Kafka To Ignite' consumer. The improvement in this pull request contains the neccessary updates to fix this issue.
What is new:
|
EventsCount| Count of messages sent to Kafka.|
LastEventTime| Timestamp of last sent event to Kafka.|
TypesCount| Count of binary types events sent to Kafka.|
MappingsCount| Count of mappings events sent to Kafka.|
BytesSent| Count of bytes sent to Kafka.|
MarkersCount| Count of metadata markers sent to Kafka.|
EventsReceivedCount| Count of events received from Kafka.|
LastEventReceivedTime| Timestamp of last received event from Kafka.|
EventsSentCount| Count of events sent to destination cluster.|
LastBatchSentTime| Timestamp of last sent batch to the destination cluster.|
MarkersCount| Count of metadata markers received from Kafka.To achieve the proposed goals, I've used
StandaloneGridKernalContextdummy context to get the manager for the metrics SPI. WithKafkaToIgniteCdcStreamerConfigurationconfigured to supply the CDC toolkit with Metrics SPIs, we are now able to register metrics exporter.