IGNITE-27437 Introduce PartitionCounterProvider #7324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korlov42
reviewed
Dec 30, 2025
| * Parameters container for {@link PartitionCountProvider#calculate}. | ||
| */ | ||
| public final class PartitionCountCalculationParameters { | ||
| /** Data nodes filter. */ |
Contributor
There was a problem hiding this comment.
such comments doesn't bring any value. Please provide meaningful one or just drop these
| * Test-only constructor. | ||
| */ | ||
| @TestOnly | ||
| public CatalogManagerImpl( |
Contributor
There was a problem hiding this comment.
let's have only one constructor. There are not so many usages
| newDefaultZoneId, | ||
| DEFAULT_ZONE_NAME, | ||
| DEFAULT_PARTITION_COUNT, | ||
| defaultZonePartitionCount(partitionCountProvider), |
Contributor
There was a problem hiding this comment.
it's better to set parameters explicitly
| /** | ||
| * Wrapper that allows to apply and use different partition count computing approaches. | ||
| */ | ||
| public final class PartitionCountProviderWrapper implements PartitionCountProvider { |
Contributor
There was a problem hiding this comment.
wrapper should be moved to runner module. Also, what about tests for this class?
| */ | ||
| public final class PartitionCountProviderWrapper implements PartitionCountProvider { | ||
| /** Wrapped delegate to compute partition count. */ | ||
| private PartitionCountProvider delegate; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: IGNITE-27437
The goal
The goal is to introduce new functional interface that computes partition count for a new zone without partition count specified.
The reason
We want to implement dynamic default partition count computation in IGNITE-27279, this PR is prerequisite.
The solution
New entities are introduced. The wrapper will use later with new producer implementation. The intention of the wrapper is to decouple catalog manager and wrapped producer update, because the last may be done outside of
IgniteImplconstructor or require components that requireCatalogManageritself. Instead of new setter for the manager better to decouple it with wrapper.