IGNITE-27350 Verify deployment contents #7310
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptupitsyn
reviewed
Dec 29, 2025
| LOG.error("Error when closing input stream.", e); | ||
| } | ||
| })); | ||
| if (collect.containsKey(filename)) { |
Contributor
There was a problem hiding this comment.
put returns previous value, we can use that to detect duplicates.
| })); | ||
| if (collect.containsKey(filename)) { | ||
| closeStream(is); | ||
| throw new DuplicateFilenamesException("Duplicate filename: " + filename); |
Contributor
There was a problem hiding this comment.
What about case-insensitive filesystems, what happens there if the file names are different only by letter case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-27350