IGNITE-27003 Log messages containing tx id, should also contain label #7304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lalant
force-pushed
the
ignite-27003-add-tx-labels-in-logs
branch
from
71234df to
5b9a0b9
Compare
| txId | ||
| ).exceptionally(throwable -> { | ||
| LOG.warn("Failed to cleanup transaction [txId={}].", throwable, txId); | ||
| LOG.warn("Failed to cleanup transaction [{}].", throwable, TransactionLogUtils.formatTxInfo(txId, txManager)); |
Contributor
There was a problem hiding this comment.
it's better to use static method imports
| import org.apache.ignite.internal.failure.FailureProcessor; | ||
| import org.apache.ignite.internal.lang.IgniteBiTuple; | ||
| import org.apache.ignite.internal.lang.IgniteInternalException; | ||
| import org.apache.ignite.internal.logger.IgniteLogger; |
Contributor
There was a problem hiding this comment.
There are also log messages mentioned in the ticket but not changed here:
Failed to acquire a lockTransaction is already finished(changed only in InternalTableImpl)
This will require changes in HeapLockManager, ReadWriteTransactionImpl, InflightTransactionalOperationTracker, PartitionReplicaListener, maybe somewhere else.
Lalant
force-pushed
the
ignite-27003-add-tx-labels-in-logs
branch
7 times, most recently
from
b785fcb to
e92a3fa
Compare
Lalant
force-pushed
the
ignite-27003-add-tx-labels-in-logs
branch
2 times, most recently
from
6ec4272 to
8e4aa17
Compare
HeapLockManager, ReadWriteTransactionImpl,PartitionReplicaListener. Applied static imports.
Lalant
force-pushed
the
ignite-27003-add-tx-labels-in-logs
branch
from
8e4aa17 to
d47a0fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…bel.
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes