IGNITE-24226 Fix flaky test WebhookSinkTest #7289
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valepakh
force-pushed
the
IGNITE-24226
branch
3 times, most recently
from
19cd2c0 to
eb10581
Compare
valepakh
force-pushed
the
IGNITE-24226
branch
from
eb10581 to
c377ecb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-24226
Sometimes, probably due to the GC pressure, awaitility doesn't get the result in time.
Let's use default timeout of 10 seconds, also to reduce leaks let's stop the sink (this will stop the internal executor) and also make the
lastSendMillisfield volatile just in case, since it's accessed from the awaitility thread.