IGNITE-26446 Allow batching for compatible DDL operations only #6835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMashenkov
force-pushed
the
ignite-26446
branch
from
e0f4bf9 to
80fb912
Compare
xtern
reviewed
Oct 24, 2025
| * @return {@code true} if statement can be added to the batch, {@code false} otherwise. | ||
| */ | ||
| static boolean canBeBatched(List<SqlNode> batch, SqlNode statement) { | ||
| return batch.stream().allMatch(s -> isCompatible(s, statement)); |
There was a problem hiding this comment.
As far as I understand, a batch can only contain identical "kinds". Should we then only compare single item of the batch?
There was a problem hiding this comment.
Fixed.
Most likely, we can relax the requirement and allow no more than one operation over the same catalog object in the single batch. WDYT?
However, it can be quite complicated. E.g. we can't create index and drop the table, which index belongs to, within the same batch.
...gine/src/main/java/org/apache/ignite/internal/sql/engine/exec/fsm/MultiStatementHandler.java
Outdated
Show resolved
Hide resolved
...gine/src/main/java/org/apache/ignite/internal/sql/engine/exec/fsm/MultiStatementHandler.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes