fix(web): improve handling of message_expiry#2888
Merged
Merged
Conversation
piotrziolko
force-pushed
the
fix/expiry-parsing
branch
2 times, most recently
from
8a8b40b to
9834aca
Compare
piotrziolko
force-pushed
the
fix/expiry-parsing
branch
from
9834aca to
be31347
Compare
spetz
approved these changes
Mar 7, 2026
hubcio
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2812
Rationale
The server changed message_expiry from seconds to microseconds The web UI was interpreting µs values as seconds, causing wildly incorrect display (e.g., 10 minutes shown as ~19 years).
What changed?
The domain mapper, duration formatter, and form modals previously assumed message_expiry was in seconds. They now correctly handle microsecond values from the server, with appropriate conversions where needed.
A new DurationInput component replaces the raw number input with text mode (e.g. "1h 30m"), numeric fields mode (d/h/min/s), a "Never" checkbox, and validation (min 1s, max 10 years)