Skip to content

feat(consensus): Add metadata and partition handles for MuxPlane#2855

Merged
hubcio merged 4 commits into
apache:masterfrom
krishvishal:meta-part-handle
Mar 4, 2026
Merged

feat(consensus): Add metadata and partition handles for MuxPlane#2855
hubcio merged 4 commits into
apache:masterfrom
krishvishal:meta-part-handle

Conversation

@krishvishal
Copy link
Copy Markdown
Contributor

The previous code accessed planes through positional tuple indexing (planes.0, planes.1.0), which was fragile and opaque. The new handle traits give each plane a semantic name, making call sites self-documenting and won't create problems when changes are made to plane ordering.

  • Introduce MetadataHandle and PartitionsHandle traits that provide typed, ergonomic accessors for the heterogeneous tuple planes inside
    MuxPlane
  • Implement these traits for the underlying tuple types (M, Tail) and (M, (P, ())), and delegate through MuxPlane

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 3, 2026

Codecov Report

❌ Patch coverage is 0% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.96%. Comparing base (118ab6a) to head (affb153).

Files with missing lines Patch % Lines
core/consensus/src/plane_mux.rs 0.00% 24 Missing ⚠️
core/shard/src/lib.rs 0.00% 10 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2855      +/-   ##
============================================
+ Coverage     67.91%   68.96%   +1.05%     
+ Complexity      739      656      -83     
============================================
  Files          1049      858     -191     
  Lines         84373    69206   -15167     
  Branches      60951    60683     -268     
============================================
- Hits          57299    47731    -9568     
+ Misses        24710    19127    -5583     
+ Partials       2364     2348      -16     
Flag Coverage Δ
go ?
node ?
python ?
rust 70.19% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
core/shard/src/lib.rs 0.00% <0.00%> (ø)
core/consensus/src/plane_mux.rs 0.00% <0.00%> (ø)

... and 207 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hubcio hubcio merged commit 50423db into apache:master Mar 4, 2026
81 of 84 checks passed
@krishvishal krishvishal deleted the meta-part-handle branch March 4, 2026 12:22
kriti-sc pushed a commit to kriti-sc/iggy that referenced this pull request Mar 6, 2026
…che#2855)

Co-authored-by: Grzegorz Koszyk <112548209+numinnex@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants