feat(go): implement TCP/TLS connection in Go SDK#2834
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2834 +/- ##
============================================
- Coverage 68.43% 67.55% -0.88%
Complexity 739 739
============================================
Files 1052 1049 -3
Lines 84635 84117 -518
Branches 61214 60653 -561
============================================
- Hits 57917 56825 -1092
- Misses 24347 24942 +595
+ Partials 2371 2350 -21
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
I can confirm. @hubcio Test issue was created and assigned to me but implementation itself was pending so I went ahead and created implementation issue. @saie-ch if it's easier, do you want to take up tests for this since you did implementation? I don't mind either. Once I get some time, I'll do a quick review as well. Currently I am assigned for #2807. |
mmodzelewski
left a comment
There was a problem hiding this comment.
Looks good, @saie-ch. @saie-ch @atharvalade could you please coordinate on who will be proceeding with the tests/examples issue? Feel free to hop on Discord to discuss it if that’s easier.
Hi @atharvalade, happy to take on the test task; I'll work on #2807. thanks:) |
Which issue does this PR close?
This unblocks issue #2807 so TCP/TLS integration tests and examples can now be written for the Go
SDK.
Rationale
The Go SDK had TLS configuration fields (tlsEnabled, tlsDomain, tlsCAFile, tlsValidateCertificate)
and TLS error types generated, but the handshake was stubbed out at line 329 with return
errors.New("TLS connection is not implemented yet"). This blocked writing integration tests and
examples for TCP/TLS connections.
What changed?
Before: Line 329 returned a stub error preventing any TLS connections.
After: Full TLS implementation with:
WithTLSValidateCertificate()
ErrInvalidTlsCertificate)
Implementation follows the same patterns as Rust (tcp_tls_connection_stream.rs), Java
(InternalTcpClient.java), C# (TcpMessageStream.cs), and Node.js (client.connection.ts) SDKs.
AI Usage
Claude Sonnet 4.5