Skip to content

Conversation

@lukaszzborek
Copy link
Contributor

  • add IggyErrorCode enum definition
  • change IggyInvalidStatusCodeException to contains IggyErrorCode
  • add tool to generate enum values from rust error file

@numinnex
Copy link
Contributor

Hi, I've looked through the PR and I really like the idea, but there is one problem tho...

Currently IggyError isn't versioned (e.g it's not an separate crate that adheres to any sane versioning standards), which means that we might change it as we wish (move/remove it, etc..), which means that on an arbitrary release (non major one), we could potentially break the C# SDK.

Since the idea is great, I would like to archive this PR and revisit it once we figure out how to extract our error into an dedicated crate, that we can version independently.

Created #2524 to address that problem.

@lukaszzborek
Copy link
Contributor Author

yep, it might be good idea for hold on it to time where will be separate crate for IggyError. It can be a bit confusing where error code will change in server.

We can also think about some CI checks for thats

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants