fix(bench): cache window sum instead of recomputing#2001
Merged
spetz merged 2 commits intoJul 15, 2025
Conversation
numinnex
approved these changes
Jul 15, 2025
spetz
approved these changes
Jul 15, 2025
T1B0
pushed a commit
to T1B0/iggy
that referenced
this pull request
Jul 16, 2025
Instead of recomputing sum of the moving window which would be O(n), we should instead just update the sum when a time point enters or leaves the moving window, which is O(1).
hageshiame
pushed a commit
to hageshiame/iggy
that referenced
this pull request
Nov 7, 2025
Instead of recomputing sum of the moving window which would be O(n), we should instead just update the sum when a time point enters or leaves the moving window, which is O(1).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2000
Instead of recomputing sum of the moving window which would be O(n), we should instead just update the sum when a time point enters or leaves the moving window, which is O(1).