refactor(integration): consolidate server tests using test matrices#1901
Merged
Conversation
hubcio
force-pushed
the
integration-refactor
branch
5 times, most recently
from
142fc34 to
defdd54
Compare
This refactoring eliminates code duplication across transport-specific server tests (TCP, QUIC, HTTP) by introducing a unified test matrix approach. The same test scenarios now run across all supported transports automatically, ensuring consistent testing coverage while reducing maintenance overhead. Key changes: - Moved benchmark utilities to a shared module (bench_utils) - Added transport() and server_addr() methods to ClientFactory trait - Created test matrices for general scenarios (all transports) and consumer group scenarios (TCP/QUIC only) - Consolidated data integrity tests to use parameterized cache settings - Removed transport-specific test files in favor of unified approach - Enhanced restart tests to verify data persistence with different segment cache configurations This change improves test maintainability by having a single source of truth for each test scenario while preserving the ability to run transport-specific tests where needed.
hubcio
force-pushed
the
integration-refactor
branch
from
defdd54 to
a804e7b
Compare
numinnex
approved these changes
Jun 22, 2025
numinnex
approved these changes
Jun 22, 2025
spetz
approved these changes
Jun 22, 2025
hageshiame
pushed a commit
to hageshiame/iggy
that referenced
this pull request
Nov 7, 2025
…pache#1901) This refactoring eliminates code duplication across transport-specific server tests (TCP, QUIC, HTTP) by introducing a unified test matrix approach. The same test scenarios now run across all supported transports automatically, ensuring consistent testing coverage while reducing maintenance overhead. Key changes: - Moved benchmark utilities to a shared module (bench_utils) - Added transport() and server_addr() methods to ClientFactory trait - Created test matrices for general scenarios (all transports) and consumer group scenarios (TCP/QUIC only) - Consolidated data integrity tests to use parameterized cache settings - Removed transport-specific test files in favor of unified approach - Enhanced restart tests to verify data persistence with different segment cache configurations This change improves test maintainability by having a single source of truth for each test scenario while preserving the ability to run transport-specific tests where needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactoring eliminates code duplication across transport-specific
server tests (TCP, QUIC, HTTP) by introducing a unified test matrix
approach. The same test scenarios now run across all supported
transports automatically, ensuring consistent testing coverage while
reducing maintenance overhead.
Key changes:
consumer group scenarios (TCP/QUIC only)
segment cache configurations
This change improves test maintainability by having a single source
of truth for each test scenario while preserving the ability to run
transport-specific tests where needed.