Skip to content

refactor(sdk): rename sync configuration to direct#1866

Merged
spetz merged 1 commit into
masterfrom
refactor/replace-sync-with-direct
Jun 13, 2025
Merged

refactor(sdk): rename sync configuration to direct#1866
spetz merged 1 commit into
masterfrom
refactor/replace-sync-with-direct

Conversation

@haze518
Copy link
Copy Markdown
Member

@haze518 haze518 commented Jun 13, 2025

These changes address issues raised during the review #1838 (comment)

The following was done:

  • Introduced a constant(MIB) for the value 1_048_576
  • Increased the maximum shard count (from 16 to 64)
  • Added additional logging when messages are accepted in a shard
  • Changed the cause type in ProducerSendFailed from String to IggyError
  • Renamed the sync module to direct
  • Added extra argument logging in LogErrorCallback

@haze518 haze518 requested a review from spetz June 13, 2025 04:08
@spetz spetz merged commit 2ce490a into master Jun 13, 2025
14 checks passed
@spetz spetz deleted the refactor/replace-sync-with-direct branch June 13, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants