feat(server): implement zero-copy message handling #1679
+12,908
−8,323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubcio
force-pushed
the
zero-copy-no-batching-rebase-3
branch
6 times, most recently
from
4a5fe65 to
c3bc623
Compare
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
haze518
reviewed
Apr 8, 2025
numinnex
requested changes
Apr 10, 2025
hubcio
force-pushed
the
zero-copy-no-batching-rebase-3
branch
4 times, most recently
from
19d4448 to
ee8bf6f
Compare
This commit introduces significant refactoring across the SDK and server to enable zero-copy operations for message polling and sending within the append-only log streaming framework. The primary goal is to improve performance by reducing memory allocations and copies, especially for message payloads, leading to lower latency and higher throughput. Changes: - Refactored Message Structures: introduced `IggyMessage` and `IggyMessagesBatchMut` / `IggyMessagesBatchSet` to handle message data with minimal copying, which replaced previous `PolledMessages` and `Message` structures in many contexts - Serialization/Deserialization: Updated the `BytesSerializable` trait and implementations to support more efficient serialization and direct buffer manipulation, avoiding intermediate copies where possible - Command Handling: Modified `PollMessages`, `SendMessages`, and corresponding server-side handlers (`poll_messages_handler`, `send_messages_handler`) to work with the new zero-copy structures and mechanisms - Client/SDK: Updated `MessageClient` trait, `IggyClient`, `IggyConsumer`, and CLI commands (`poll-messages`, `send-messages`) to align with the new message handling logic This is BREAKING_CHANGE.
hubcio
force-pushed
the
zero-copy-no-batching-rebase-3
branch
from
ee8bf6f to
c58ef05
Compare
hubcio
force-pushed
the
zero-copy-no-batching-rebase-3
branch
2 times, most recently
from
9f60ac9 to
5cf4d75
Compare
hubcio
force-pushed
the
zero-copy-no-batching-rebase-3
branch
from
5cf4d75 to
34e3a91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces significant refactoring across the SDK and server to enable zero-copy operations for message polling and sending within the append-only log streaming framework.
The primary goal is to improve performance by reducing memory allocations and copies, especially for message payloads, leading to lower latency and higher throughput.
Changes:
IggyMessageandIggyMessagesBatchMut/IggyMessagesBatchSetto handle message data with minimal copying, which replaced previousPolledMessagesandMessagestructures in many contextsBytesSerializabletrait and implementations to support more efficient serialization and direct buffer manipulation, avoiding intermediate copies where possiblePollMessages,SendMessages, and corresponding server-side handlers (poll_messages_handler,send_messages_handler) to work with the new zero-copy structures and mechanismsMessageClienttrait,IggyClient,IggyConsumer, and CLI commands (poll-messages,send-messages) to align with the new message handling logic