Hive: Tests to do validation hive content and iceberg table with the same name #9980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nk1506
changed the title
nastra
reviewed
Mar 22, 2024
|
|
||
| catalog.setListAllTables(true); | ||
| List<TableIdentifier> tableIdents2 = catalog.listTables(TABLE_IDENTIFIER.namespace()); | ||
| assertThat(tableIdents2).as("should be 2 tables in namespace .").hasSize(2); |
There was a problem hiding this comment.
this should also use .containsExactly(..) to check what exactly comes back
There was a problem hiding this comment.
assertThat(catalog.listTables(TABLE_IDENTIFIER.namespace())).hasSize(2).containsExactly(...) (no need to define List<TableIdentifier> tableIdents2)
nastra
reviewed
Mar 22, 2024
| throws IOException { | ||
| @Test | ||
| public void testHiveTableAndIcebergTableWithSameName() throws TException, IOException { | ||
| List<TableIdentifier> tableIdents = catalog.listTables(TABLE_IDENTIFIER.namespace()); |
There was a problem hiding this comment.
no need to store this in a variable
nastra
reviewed
Mar 22, 2024
| @Test | ||
| public void testHiveTableAndIcebergTableWithSameName() throws TException, IOException { | ||
| List<TableIdentifier> tableIdents = catalog.listTables(TABLE_IDENTIFIER.namespace()); | ||
| assertThat(tableIdents).as("should be 1 table in namespace .").hasSize(1); |
There was a problem hiding this comment.
Suggested change
| assertThat(tableIdents).as("should be 1 table in namespace .").hasSize(1); | |
| assertThat(catalog.listTables(TABLE_IDENTIFIER.namespace())).hasSize(1).containsExactly(...); |
nastra
reviewed
Mar 22, 2024
| catalog.createTable( | ||
| identifierWithHiveTableName, schema, PartitionSpec.unpartitioned())) | ||
| .isInstanceOf(NoSuchIcebergTableException.class) | ||
| .hasMessageStartingWith("Not an iceberg table: hive.hivedb.test_hive_table"); |
There was a problem hiding this comment.
Suggested change
| .hasMessageStartingWith("Not an iceberg table: hive.hivedb.test_hive_table"); | |
| .hasMessageStartingWith(String.format("Not an iceberg table: %s", identifier)); |
nastra
reviewed
Mar 22, 2024
| List<TableIdentifier> tableIdents2 = catalog.listTables(TABLE_IDENTIFIER.namespace()); | ||
| assertThat(tableIdents2).as("should be 2 tables in namespace .").hasSize(2); | ||
|
|
||
| TableIdentifier identifierWithHiveTableName = TableIdentifier.of(DB_NAME, hiveTableName); |
There was a problem hiding this comment.
Suggested change
| TableIdentifier identifierWithHiveTableName = TableIdentifier.of(DB_NAME, hiveTableName); | |
| TableIdentifier identifier = TableIdentifier.of(DB_NAME, hiveTableName); |
nastra
reviewed
Mar 22, 2024
| } | ||
|
|
||
| @Test | ||
| public void testHiveViewAndIcebergTableWithSameName() throws TException, IOException { |
There was a problem hiding this comment.
please also reflect the comments from above in this test method
nastra
reviewed
Mar 22, 2024
| @@ -349,8 +351,70 @@ public void testListTables() throws TException, IOException { | |||
| HIVE_METASTORE_EXTENSION.metastoreClient().dropTable(DB_NAME, hiveTableName); | |||
| } | |||
|
|
|||
| private org.apache.hadoop.hive.metastore.api.Table createHiveTable(String hiveTableName) | |||
| throws IOException { | |||
| @Test | |||
There was a problem hiding this comment.
you could change this to a @ParameterizedTest, since the only difference between the two tests is the TableType. So the test would have a TableType parameter, where you pass TableType.EXTERNAL_TABLE and TableType.VIRTUAL_VIEW via @EnumSource (there are examples in the codebase on how to use parameterized tests with enums)
nastra
reviewed
Mar 25, 2024
| import org.junit.jupiter.api.io.TempDir; | ||
|
|
||
| @ExtendWith(ParameterizedTestExtension.class) |
There was a problem hiding this comment.
you don't have to make the full class a parameterized test.
nastra
reviewed
Mar 26, 2024
nastra
approved these changes
Mar 26, 2024
sasankpagolu
pushed a commit
to sasankpagolu/iceberg
that referenced
this pull request
Oct 27, 2024
…e can't be created (apache#9980)
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
…e can't be created (apache#9980)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hive should not allow creating an iceberg table, if there is already another content available with same name.
@pvary / @szehon-ho Please share your feedback for these tests.