-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add issue template and docs for iceberg proposals #9932
Conversation
@jbonofre I'm not sure why I can't add you as a reviewer. |
What I observed is only collaborators, committers can be added as reviewer. So, I manually CC them in the PR for review if required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, just added some minor nits.
@danielcweeks That's because my user is not in the |
Co-authored-by: Renjie Liu <liurenjie2008@gmail.com>
Co-authored-by: Renjie Liu <liurenjie2008@gmail.com>
Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add issue template and docs for iceberg proposals * Add vote clarification * Update site/docs/contribute.md Co-authored-by: Renjie Liu <liurenjie2008@gmail.com> * Update site/docs/contribute.md Co-authored-by: Renjie Liu <liurenjie2008@gmail.com> * Update .github/ISSUE_TEMPLATE/iceberg_proposal.yml Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com> * Fix issue template link * Address comments --------- Co-authored-by: Renjie Liu <liurenjie2008@gmail.com> Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com>
This PR adds an issue template for Iceberg improvement proposals and adds docs to the site to cover the proposal process.